Attention is currently required from: dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 )

Change subject: mgcp_codec: fix codec decision ......................................................................

Patch Set 4:

(3 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/f8984686_c8f541bf PS4, Line 509: return; so you decided to drop the return code while still logging an ERROR. WHY?

https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/59799fe7_89329e4d PS4, Line 1166: mgcp_patch_pt(conn_dst, msg); all this code path failing looks buggy. Looks like it was buggy before, but now it looks even worse?

File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/0471b13a_8cc51dee PS4, Line 703: "allow-transcoding", "Allow transcoding\n") These are still missing the deprecated warnings?