Attention is currently required from: dexter.

View Change

3 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #4, Line 509: return;

    so you decided to drop the return code while still logging an ERROR. WHY?

  • Patch Set #4, Line 1166: mgcp_patch_pt(conn_dst, msg);

    all this code path failing looks buggy. Looks like it was buggy before, but now it looks even worse?

• File src/libosmo-mgcp/mgcp_vty.c:

  • Patch Set #4, Line 703: "allow-transcoding", "Allow transcoding\n")

    These are still missing the deprecated warnings?

To view, visit change 32218. To unsubscribe, or for help writing mail filters, visit settings.