Attention is currently required from: dexter, laforge.

neels has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email )

Change subject: pySim.esim.saip.personalization: Support Milenage customization ......................................................................

Patch Set 1:

(3 comments)

Patchset:

PS1: general remark: on my saip branch, I will need each ConfigurableParameter to be able to convert some or other string input to the correct type. You don't need to worry about this here, i have it covered on the branch.

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/41690/comment/f7c28278_0be1b87e?usp=ema... : PS1, Line 327: Provided as octet-string concatenation of all 5 constants.""" Which type exactly goes into the PES?

I assume it is a bytes() of len() = 5 octets? i.e. not a hex string, right?

(i'm pretty sure it's not, but from the doc one could get the idea that the highest unused bit might be stripped to leave 5 * 7 bits)

https://gerrit.osmocom.org/c/pysim/+/41690/comment/0650529a_bde4714d?usp=ema... : PS1, Line 341: super().validate()

Looks like you want to call this first, before checking length of something that may not be a `bytes […]

(On my branch I will inherit from BinaryParam,AlgoConfig and set allowed_len, so this won't need its own validate() implementation. That can happen later when the branch gets merged.)