Attention is currently required from: dexter, laforge.
3 comments:
Patchset:
general remark: on my saip branch, I will need each ConfigurableParameter to be able to convert some or other string input to the correct type. You don't need to worry about this here, i have it covered on the branch.
File pySim/esim/saip/personalization.py:
Patch Set #1, Line 327: Provided as octet-string concatenation of all 5 constants."""
Which type exactly goes into the PES?
I assume it is a bytes() of len() = 5 octets? i.e. not a hex string, right?
(i'm pretty sure it's not, but from the doc one could get the idea that the highest unused bit might be stripped to leave 5 * 7 bits)
Patch Set #1, Line 341: super().validate()
Looks like you want to call this first, before checking length of something that may not be a `bytes […]
(On my branch I will inherit from BinaryParam,AlgoConfig and set allowed_len, so this won't need its own validate() implementation. That can happen later when the branch gets merged.)
To view, visit change 41690. To unsubscribe, or for help writing mail filters, visit settings.