Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email ) Change subject: ss7 vty: Fix insert order of routes with higher priority ...................................................................... Patch Set 3: (8 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/5ec169d3_160a5… : PS2, Line 664: noy Done File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/54bb3788_d6852… : PS3, Line 664: insertd inserted https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/2d6c6b1d_6d4de… : PS3, Line 681: struct osmo_ss7_route * put this into the same line as the function name? same for: * osmo_ss7_route_set_linkset * osmo_ss7_route_insert https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/b2320e8d_3294e… : PS3, Line 736: return -ENODEV; other error returns above log a message. log one here too for consistency? https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/7a8872fa_35f20… : PS3, Line 857: LOGSS7(rtbl->inst, LOGL_ERROR, "Refusing to create duplicate route: " maybe be more specific here: "Refusing to create route with existing linkset name" https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/f1c470df_dffba… : PS3, Line 902: } (I thought a rc < 0 case is missing here, but looks like you handled all cases before so this is not possible.) File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/6010e0d7_ee01b… : PS3, Line 401: find set? File tests/vty/osmo_stp_route_prio.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/a0d90c34_00c38… : PS2, Line 71: Os Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218 Gerrit-Change-Number: 38375 Gerrit-PatchSet: 3 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 10 Oct 2024 13:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;