Attention is currently required from: fixeria, pespin.

View Change

8 comments:

• File src/osmo_ss7.c:

  • Patch Set #2, Line 664: noy

    typo: not

    Done

• File src/osmo_ss7.c:

  • Patch Set #3, Line 664: insertd

    inserted

  • Patch Set #3, Line 681: struct osmo_ss7_route *

    put this into the same line as the function name? same for:

    • osmo_ss7_route_set_linkset
    • osmo_ss7_route_insert

  • Patch Set #3, Line 736: return -ENODEV;

    other error returns above log a message. log one here too for consistency?

  • Patch Set #3, Line 857: LOGSS7(rtbl->inst, LOGL_ERROR, "Refusing to create duplicate route: "

    maybe be more specific here: "Refusing to create route with existing linkset name"

  • Patch Set #3, Line 902: }

    (I thought a rc < 0 case is missing here, but looks like you handled all cases before so this is not possible.)

• File src/osmo_ss7_vty.c:

  • Patch Set #3, Line 401: find

    set?

• File tests/vty/osmo_stp_route_prio.vty:

  • Patch Set #2, Line 71: Os

    This comment should be removed now?

    Done

To view, visit change 38375. To unsubscribe, or for help writing mail filters, visit settings.