Attention is currently required from: daniel, fixeria, laforge, osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )

Change subject: stp: Introduce tests to validate inaccessible SP scenario ......................................................................

Patch Set 2:

(1 comment)

File stp/STP_Tests_M3UA.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/45bb59ed_5a77b... : PS2, Line 207: "while waiting for ", msg));

the first message could mention that the message is unexpected within the timer

It does: "received unexpected M3UA".

wonder if the msg parameter is even useful,

It is, because it quickly tells you which message arrived. I think this second branch is still useful because it tells you of non-envisioned scenarios for the test, besides the one specific obvious/known scenario. So it's good to have them diffentiated, and it's good to have it since it may uncover other bugs.

I think in general the comments are fine, in the end they are useful to get a file+line and see where it fails, when it becomes obvious, but I'll try to improve the strings.