Attention is currently required from: daniel, fixeria, laforge, osmith.

View Change

1 comment:

• File stp/STP_Tests_M3UA.ttcn:

  • Patch Set #2, Line 207: "while waiting for ", msg));

    the first message could mention that the message is unexpected within the timer

    It does: "received unexpected M3UA".

     wonder if the msg parameter is even useful,

    It is, because it quickly tells you which message arrived. I think this second branch is still useful because it tells you of non-envisioned scenarios for the test, besides the one specific obvious/known scenario. So it's good to have them diffentiated, and it's good to have it since it may uncover other bugs.

    I think in general the comments are fine, in the end they are useful to get a file+line and see where it fails, when it becomes obvious, but I'll try to improve the strings.

To view, visit change 41525. To unsubscribe, or for help writing mail filters, visit settings.