Attention is currently required from: dexter, laforge.

fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39860?usp=email )

Change subject: saip-tool: add features to add and remove applications profile elements ......................................................................

Patch Set 1:

(5 comments)

File contrib/saip-tool.py:

https://gerrit.osmocom.org/c/pysim/+/39860/comment/f238e89a_fab73d6e?usp=ema... : PS1, Line 22: import zipfile

removing those unused imports is a logically separate change, isn't it?

Acknowledged

https://gerrit.osmocom.org/c/pysim/+/39860/comment/bf59f361_b00e6312?usp=ema... : PS1, Line 250: if dictionary is None: The type hint `:dict` suggests that it cannot be `None`, change to `Optional[dict]` then?

https://gerrit.osmocom.org/c/pysim/+/39860/comment/ba8d4bce_3c0ba022?usp=ema... : PS1, Line 255: elif value is None: : Looks like a no-op branch that can be removed without any consequences?

https://gerrit.osmocom.org/c/pysim/+/39860/comment/5109e147_a6e47968?usp=ema... : PS1, Line 268: for app_pe in apps: You can drop `app_index` above and use `enumerate()` instead:

``` for app_index, app_pe in enumerate(apps): ```

This way there's no need to maintain the counter manually.

https://gerrit.osmocom.org/c/pysim/+/39860/comment/4ec99c16_30eea229?usp=ema... : PS1, Line 283: for inst in app_pe.decoded.get('instanceList', []): Likewise, use `enumerate()` here.