Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39860?usp=email ) Change subject: saip-tool: add features to add and remove applications profile elements ...................................................................... Patch Set 1: (5 comments) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39860/comment/f238e89a_fab73d6e?usp=em… : PS1, Line 22: import zipfile Acknowledged https://gerrit.osmocom.org/c/pysim/+/39860/comment/bf59f361_b00e6312?usp=em… : PS1, Line 250: if dictionary is None: The type hint `:dict` suggests that it cannot be `None`, change to `Optional[dict]` then? https://gerrit.osmocom.org/c/pysim/+/39860/comment/ba8d4bce_3c0ba022?usp=em… : PS1, Line 255: elif value is None: : Looks like a no-op branch that can be removed without any consequences? https://gerrit.osmocom.org/c/pysim/+/39860/comment/5109e147_a6e47968?usp=em… : PS1, Line 268: for app_pe in apps: You can drop `app_index` above and use `enumerate()` instead: ``` for app_index, app_pe in enumerate(apps): ``` This way there's no need to maintain the counter manually. https://gerrit.osmocom.org/c/pysim/+/39860/comment/4ec99c16_30eea229?usp=em… : PS1, Line 283: for inst in app_pe.decoded.get('instanceList', []): Likewise, use `enumerate()` here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I41db96f2f0ccc29c1725a92215ce6b17d87b76ce Gerrit-Change-Number: 39860 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:44:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>