Attention is currently required from: dexter, laforge.

View Change

5 comments:

• File contrib/saip-tool.py:

  • Patch Set #1, Line 22: import zipfile

    removing those unused imports is a logically separate change, isn't it?

    Acknowledged

  • Patch Set #1, Line 250: if dictionary is None:

    The type hint `:dict` suggests that it cannot be `None`, change to `Optional[dict]` then?

  • Patch Set #1, Line 255:

            elif value is None:
      
    

    Looks like a no-op branch that can be removed without any consequences?

  • Patch Set #1, Line 268: for app_pe in apps:

    You can drop `app_index` above and use `enumerate()` instead:

    ```
    for app_index, app_pe in enumerate(apps):
    ```

    This way there's no need to maintain the counter manually.

  • Patch Set #1, Line 283: for inst in app_pe.decoded.get('instanceList', []):

    Likewise, use `enumerate()` here.

To view, visit change 39860. To unsubscribe, or for help writing mail filters, visit settings.