Attention is currently required from: osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36576?usp=email )

Change subject: cbsp_link.c: Update stream_cli read_cb2 functions to accommodate for new API param ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bsc/cbsp_link.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/36576/comment/37a19e47_6b045711 PS1, Line 166: } */

maybe add log messages instead of having the commented out code?

I'm basically leaving the code which was there before and got removed when moving to osmo_io, but simply commenting it out since it really is a no-op. Still I think it's useful keeping it in case someone wants to do more fine-grained error handling.

85687bf176e4b9663f2396a27c28b49221c72fa3:

- /* READ */ - rc = osmo_cbsp_recv_buffered(cbc, ofd->fd, &msg, &cbc->client.msg); - if (rc <= 0) { - if (rc == -EAGAIN || rc == -EINTR) { - /* more data needs to be read */ - return 0; - } else if (rc == -EPIPE || rc == -ECONNRESET) { - /* lost connection */ - } else if (rc == 0) { - /* connection closed */ - } - osmo_stream_cli_reconnect(cli); - return -EBADF; - }