Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36576?usp=email ) Change subject: cbsp_link.c: Update stream_cli read_cb2 functions to accommodate for new API param ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-bsc/+/36576/comment/37a19e47_6b045711 PS1, Line 166: } */ I'm basically leaving the code which was there before and got removed when moving to osmo_io, but simply commenting it out since it really is a no-op. Still I think it's useful keeping it in case someone wants to do more fine-grained error handling. 85687bf176e4b9663f2396a27c28b49221c72fa3: - /* READ */ - rc = osmo_cbsp_recv_buffered(cbc, ofd->fd, &msg, &cbc->client.msg); - if (rc <= 0) { - if (rc == -EAGAIN || rc == -EINTR) { - /* more data needs to be read */ - return 0; - } else if (rc == -EPIPE || rc == -ECONNRESET) { - /* lost connection */ - } else if (rc == 0) { - /* connection closed */ - } - osmo_stream_cli_reconnect(cli); - return -EBADF; - } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4cce5cb6ca98bc28a67dd6e927e9cdfd2312851a Gerrit-Change-Number: 36576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 18 Apr 2024 09:54:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-MessageType: comment