Attention is currently required from: osmith.

View Change

1 comment:

• File src/osmo-bsc/cbsp_link.c:

  • Patch Set #1, Line 166: } */

    maybe add log messages instead of having the commented out code?

    I'm basically leaving the code which was there before and got removed when moving to osmo_io, but simply commenting it out since it really is a no-op. Still I think it's useful keeping it in case someone wants to do more fine-grained error handling.

    85687bf176e4b9663f2396a27c28b49221c72fa3:

        -       /* READ */
        -       rc = osmo_cbsp_recv_buffered(cbc, ofd->fd, &msg, &cbc->client.msg);
        -       if (rc <= 0) {
        -               if (rc == -EAGAIN || rc == -EINTR) {
        -                       /* more data needs to be read */
        -                       return 0;
        -               } else if (rc == -EPIPE || rc == -ECONNRESET) {
        -                       /* lost connection */
        -               } else if (rc == 0) {
        -                       /* connection closed */
        -               }
        -               osmo_stream_cli_reconnect(cli);
        -               return -EBADF;
        -       }

To view, visit change 36576. To unsubscribe, or for help writing mail filters, visit settings.