[S] Change in osmo-pcu[master]: Avoid using UL TBF in RELEASE state to assign DL TBF over PACCH - gerrit-log

26 Jun 2023


      Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33453 )
Change subject: Avoid using UL TBF in RELEASE state to assign DL TBF over PACCH
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/33453/comment/e728bea8_34ef07e9 
PS2, Line 1108: 	if (ul_tbf_contention_resolution_done(ul_tbf) &&
IMO, it would be more readable to invert these conditions and have three separate `if (!cond) return false;` statements, but not critical.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33453
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia11f7802779cfeea15a71bddad9f7e0c6c1afb11
Gerrit-Change-Number: 33453
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 26 Jun 2023 14:29:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment