Attention is currently required from: pespin.
Patch set 2:Code-Review +1
View Change
1 comment:
File src/gprs_ms.c:
Patch Set #2, Line 1108: if (ul_tbf_contention_resolution_done(ul_tbf) &&
IMO, it would be more readable to invert these conditions and have three separate `if (!cond) return false;` statements, but not critical.
To view, visit change 33453. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia11f7802779cfeea15a71bddad9f7e0c6c1afb11
Gerrit-Change-Number: 33453
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 14:29:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment