Attention is currently required from: jolly, laforge.

pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email )

Change subject: Allow io_uring_submit batching just ahead of poll/select ......................................................................

Patch Set 4: Code-Review-1

(6 comments)

Patchset:

PS4: Fine with having the extra envvar for now (I guess we'll want to remove it later on once we figure out this new approach is good).

Marking -1 because the optimization to skip calling io_uring if not needed was not yet added. See comments attached.

File src/core/osmo_io_uring.c:

https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/2c959aae_fcaa711d?u... : PS4, Line 187: io_uring_submit(&g_ring.ring); else g_io_uring_submit_needed = true;

https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/5232545f_41388f48?u... : PS4, Line 330: io_uring_submit(&g_ring.ring); else g_io_uring_submit_needed = true;

https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/cf237e81_db669c01?u... : PS4, Line 431: io_uring_submit(&g_ring.ring); else g_io_uring_submit_needed = true;

https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/a42061d3_c42803d3?u... : PS4, Line 480: if (OSMO_LIKELY(!g_io_uring_batch)) else g_io_uring_submit_needed = true;

(and yes, you probably want to have this as a static inline function to avoid logic duplication: io_uring_submit_needed()).

https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/1d96d8f0_ed7dcc1a?u... : PS4, Line 554: io_uring_submit(&g_ring.ring); if (OSMO_LIKELY(g_io_uring_submit_needed)) io_uring_submit(&g_ring.ring);