Attention is currently required from: jolly, laforge.

Patch set 4:Code-Review -1

View Change

6 comments:

• Patchset:

  • Patch Set #4:

    Fine with having the extra envvar for now (I guess we'll want to remove it later on once we figure out this new approach is good).

    Marking -1 because the optimization to skip calling io_uring if not needed was not yet added. See comments attached.

• File src/core/osmo_io_uring.c:

  • Patch Set #4, Line 187: io_uring_submit(&g_ring.ring);

    else
             g_io_uring_submit_needed = true;

  • Patch Set #4, Line 330: io_uring_submit(&g_ring.ring);

    else
             g_io_uring_submit_needed = true;

  • Patch Set #4, Line 431: io_uring_submit(&g_ring.ring);

    else
             g_io_uring_submit_needed = true;

  • Patch Set #4, Line 480: if (OSMO_LIKELY(!g_io_uring_batch))

    else
             g_io_uring_submit_needed = true;
             
    (and yes, you probably want to have this as a static inline function to avoid logic duplication: io_uring_submit_needed()).

  • Patch Set #4, Line 554: io_uring_submit(&g_ring.ring);

    if (OSMO_LIKELY(g_io_uring_submit_needed))
             io_uring_submit(&g_ring.ring);

To view, visit change 40489. To unsubscribe, or for help writing mail filters, visit settings.