Attention is currently required from: clufn, fixeria. pespin has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email ) Change subject: Enable the use of an UE requested IP type and address to be used for gtpv2 PDN Address Allocation ...................................................................... Patch Set 2: (2 comments) File src/epdg_ue_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/2b4e81fb_e953… : PS1, Line 264: Data1 = Data#ue_fsm_data{paa = conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn}, Yes that's be the preferred way imho. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/5c3a20b1_596c… : PS1, Line 353: Data#ue_fsm_data.paa, I think it makes sense to pass PdpAddress and PfpTypeNr to create_session_req and do the conversion there, but I'd be also fine with having the conversion in this line. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: If0c77b1e366df36439d3a1b72030d831dd1b3a05 Gerrit-Change-Number: 40277 Gerrit-PatchSet: 2 Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Comment-Date: Mon, 12 May 2025 09:58:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: clufn <callumfarrbennett(a)yahoo.com>