Attention is currently required from: clufn, fixeria.

View Change

2 comments:

• File src/epdg_ue_fsm.erl:

  • Patch Set #1, Line 264: Data1 = Data#ue_fsm_data{paa = conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn},

    I could add the pdp type and address to the eu_fsm_data instead and then pass it through to the epdg […]

    Yes that's be the preferred way imho.

  • Patch Set #1, Line 353: Data#ue_fsm_data.paa,

    Can do it here as PdpTypeNr and PdpAddress are not passed in the calling of the tunnel request funct […]

    I think it makes sense to pass PdpAddress and PfpTypeNr to create_session_req and do the conversion there, but I'd be also fine with having the conversion in this line.

To view, visit change 40277. To unsubscribe, or for help writing mail filters, visit settings.