Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30539 )
Change subject: WIP: vty: Add support for ny1 configuration ......................................................................
Patch Set 4:
(5 comments)
This change is ready for review.
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/9134ef70_55672145 PS1, Line 888: int ny1;
It's a counter. We use osmo_tdef for counters too. See gsm_network_T_defs. […]
Done
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/fe0dcc6a_e18375a6 PS1, Line 2452: DEFUN_ATTR(cfg_net_ny1, cfg_net_ny1_cmd,
This should be implemented using osmo_tdef, see "timer " just above.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/1068cac8_34d453c1 PS1, Line 2469: static void net_init_ny1(int ntype, struct cmd_element *cmd, struct gsm_network *gsm_net)
No need for this function.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/2b15bb82_286cf211 PS1, Line 2472: gsm_net->ny1 = GSM_NY1_DEFAULT;
If you didn't use osmo_tdef, this should be set in the "network" init/alloc function. […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/26cd0944_d9605c17 PS1, Line 2475: DEFUN(show_ny1, show_ny1_cmd,
This may be not needed when you move to osmo_tdef.
Done
-
arehbein