Attention is currently required from: pespin.

View Change

5 comments:

• File include/osmocom/bsc/gsm_data.h:

  • Patch Set #1, Line 888: int ny1;

    It's a counter. We use osmo_tdef for counters too. See gsm_network_T_defs. […]

    Done

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #1, Line 2452: DEFUN_ATTR(cfg_net_ny1, cfg_net_ny1_cmd,

    This should be implemented using osmo_tdef, see "timer " just above.

    Done

  • Patch Set #1, Line 2469: static void net_init_ny1(int ntype, struct cmd_element *cmd, struct gsm_network *gsm_net)

    No need for this function.

    Done

  • Patch Set #1, Line 2472: gsm_net->ny1 = GSM_NY1_DEFAULT;

    If you didn't use osmo_tdef, this should be set in the "network" init/alloc function. […]

    Done

  • Patch Set #1, Line 2475: DEFUN(show_ny1, show_ny1_cmd,

    This may be not needed when you move to osmo_tdef.

    Done

To view, visit change 30539. To unsubscribe, or for help writing mail filters, visit settings.