Attention is currently required from: fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/33593
)
Change subject: csd_bs_list_remove: fix removal logic
......................................................................
Patch Set 2:
(1 comment)
File src/libmsc/csd_bs.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33593/comment/de423c14_612c7989
PS1, Line 352: i <= list->count
Comment removed by: osmith; Reason: typo
right!
it must be `i + 1 < list->count`. (as it is in v2 of the patch now.)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/33593
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I638d4e063fee6bad45ab14d8ad6b9ad847a7127a
Gerrit-Change-Number: 33593
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Jul 2023 11:16:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment