Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33593 ) Change subject: csd_bs_list_remove: fix removal logic ...................................................................... Patch Set 2: (1 comment) File src/libmsc/csd_bs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33593/comment/306797b0_ec02710b PS1, Line 352: i <= list->count

Are you sure this is correct? Aren't we overrunning the `list` when `i == list->count`? right! it must be i + 1 < = list->count.

-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I638d4e063fee6bad45ab14d8ad6b9ad847a7127a Gerrit-Change-Number: 33593 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 11:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment