Attention is currently required from: neels, pespin, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 15: (7 comments) File include/osmocom/bsc/bts_setup_ramp.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/6d17b724_0b60a368 PS3, Line 31: BTS_SETUP_RAMP_INIT, /** initial state */ I am surprised it took so many iterations, but still does not match what Neels actually suggested. There should be only one '*' (not two) followed by the '<'. Anyways, I am giving up here. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/a80d636b_ed568edd PS4, Line 3100: bts-setup-ramping-step-interval I am sorry, but no. This should be addressed before merging. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/5deabe72_c4299b46 PS15, Line 3121: The amount of BTS while a step interval This sentence is somehow wrong, please rephrase. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/f1cffb23_f1de5f0f PS4, Line 98: && net->bts_setup_ramp.step_size > 0 Not addressed. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/98007115_0d9bcd84 PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); Comment was not added. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/01ca7619_a3f0c97f PS15, Line 51: if (llist_empty(&bts->bts_setup_ramp.list)) Why don't you check the bts->bts_setup_ramp.state against BTS_SETUP_RAMP_WAIT here? It's this the purpose of the state? https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/35edfab8_c3462a8e PS15, Line 74: net->bts_setup_ramp.count >= net->bts_setup_ramp.step_size) This line needs to be aligned to the opening brace, otherwise it looks like the block's body. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Comment-Date: Fri, 11 Nov 2022 05:41:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-MessageType: comment