Attention is currently required from: neels, pespin, lynxis lazus.

View Change

7 comments:

• File include/osmocom/bsc/bts_setup_ramp.h:

  • Patch Set #3, Line 31: BTS_SETUP_RAMP_INIT, /** initial state */

    Done

    I am surprised it took so many iterations, but still does not match what Neels actually suggested. There should be only one '*' (not two) followed by the '<'. Anyways, I am giving up here.

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #4, Line 3100: bts-setup-ramping-step-interval

    Good idea. Please do a follow-up patch after this commit has been merged.

    I am sorry, but no. This should be addressed before merging.

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #15, Line 3121: The amount of BTS while a step interval

    This sentence is somehow wrong, please rephrase.

• File src/osmo-bsc/bts_setup_ramp.c:

  • Patch Set #4, Line 98: && net->bts_setup_ramp.step_size > 0

    Ack

    Not addressed.

  • Patch Set #4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list);

    Done

    Comment was not added.

• File src/osmo-bsc/bts_setup_ramp.c:

  • Patch Set #15, Line 51: if (llist_empty(&bts->bts_setup_ramp.list))

    Why don't you check the bts->bts_setup_ramp.state against BTS_SETUP_RAMP_WAIT here?
    It's this the purpose of the state?

  • Patch Set #15, Line 74: net->bts_setup_ramp.count >= net->bts_setup_ramp.step_size)

    This line needs to be aligned to the opening brace, otherwise it looks like the block's body.

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.