Attention is currently required from: jolly, laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email )

Change subject: Automatically reset RIFO on underrun/overflow ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/545e43dd_8de573c1 PS1, Line 18: twice the value of max_frame_count. It specifies when the RIFO will max_frame_count is set to twice the value of max_frame_count? Sounds wrong.

File src/octoi/e1oip.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/3bde4046_34241e5f PS1, Line 272: if (rc < 0) { did you think about returning a specific error code to signal this exact error? like -ERANGE.

File src/octoi/frame_rifo.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/d375c806_1eb31ddd PS1, Line 106: int frame_rifo_in(struct frame_rifo *rifo, const uint8_t *frame, uint32_t fn, int max_frame_count) can max_frame_count be negative? unsigned?