Attention is currently required from: jolly, laforge.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 18: twice the value of max_frame_count. It specifies when the RIFO will

    max_frame_count is set to twice the value of max_frame_count? Sounds wrong.

• File src/octoi/e1oip.c:

  • Patch Set #1, Line 272: if (rc < 0) {

    did you think about returning a specific error code to signal this exact error? like -ERANGE.

• File src/octoi/frame_rifo.c:

  • Patch Set #1, Line 106: int frame_rifo_in(struct frame_rifo *rifo, const uint8_t *frame, uint32_t fn, int max_frame_count)

    can max_frame_count be negative? unsigned?

To view, visit change 34554. To unsubscribe, or for help writing mail filters, visit settings.