[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta... - gerrit-log

25 Feb 2025

Attention is currently required from: csaba.sipos, domi, fixeria, pespin.

laforge has posted comments on this change by csaba.sipos. (
https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state
attributes
......................................................................

Patch Set 22:

(8 comments)

Patchset:

PS22: 
please make sure to mark review comments as done if they are addressed. Otherwise you will
discourage further review.  I usually only review code where other review issues are
resolved already.

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/a364b58f_b871dd90?usp… :
PS14, Line 1716: #define FIND_ELEM(data, data_len, ei, var) (find_element(data, data_len,
ei, var, sizeof(var)) == sizeof(var))
...
  Let me put this back to WIP, as this must be grossly
annoying. […] Done

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/90554bee_ab3c887d?usp… :
PS21, Line 1828: 				get_object_identity_string(object_id_state[4]),
...
  If you want I send you a printscreen that it looks
perfect on my side. Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/b2f4015b_64f2d63c?usp… :
PS21, Line 1876: 						get_object_identity_string(object_identity[1]),
...
  Same as on the first one. Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/cf279dd0_40af37b8?usp… :
PS21, Line 1884: 						get_object_identity_string(object_identity[1]),
...
  Same as on the first one. Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/97d372e4_e9896905?usp… :
PS21, Line 1898: 						get_object_identity_string(object_identity[1]),
...
  wrong indentation Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/0a95b997_63eb4962?usp… :
PS21, Line 1907: 						get_object_identity_string(object_identity[1]),
...
  wrong indentation Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/cf6a8bef_118f89c9?usp… :
PS21, Line 1916: 					object_identity[2],
...
  wrong indentation Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3
Gerrit-Change-Number: 39416
Gerrit-PatchSet: 22
Gerrit-Owner: csaba.sipos &lt;metro4(a)freemail.hu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: domi &lt;domi(a)tomcsanyi.net&gt;
Gerrit-Attention: csaba.sipos &lt;metro4(a)freemail.hu&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: domi &lt;domi(a)tomcsanyi.net&gt;
Gerrit-Comment-Date: Tue, 25 Feb 2025 07:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: csaba.sipos &lt;metro4(a)freemail.hu&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;