Attention is currently required from: csaba.sipos, domi, fixeria, pespin.

8 comments:

Patchset:
- Patch Set #22:
  please make sure to mark review comments as done if they are addressed. Otherwise you will discourage further review. I usually only review code where other review issues are resolved already.
File src/osmo-bsc/bts_nokia_site.c:
- Patch Set #14, Line 1716: #define FIND_ELEM(data, data_len, ei, var) (find_element(data, data_len, ei, var, sizeof(var)) == sizeof(var))
  Let me put this back to WIP, as this must be grossly annoying. […]
  Done
File src/osmo-bsc/bts_nokia_site.c:
- Patch Set #21, Line 1828: get_object_identity_string(object_id_state[4]),
  If you want I send you a printscreen that it looks perfect on my side.
  Done
- Patch Set #21, Line 1876: get_object_identity_string(object_identity[1]),
  Same as on the first one.
  Done
- Patch Set #21, Line 1884: get_object_identity_string(object_identity[1]),
  Same as on the first one.
  Done
- Patch Set #21, Line 1898: get_object_identity_string(object_identity[1]),
  wrong indentation
  Done
- Patch Set #21, Line 1907: get_object_identity_string(object_identity[1]),
  wrong indentation
  Done
- Patch Set #21, Line 1916: object_identity[2],
  wrong indentation
  Done

To view, visit change 39416. To unsubscribe, or for help writing mail filters, visit settings.