Attention is currently required from: laforge, lynxis lazus, pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email )

Change subject: msc: add TC_silent_call_{start_stop,active_conn} ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/299a305e_10b4a... : PS4, Line 7720: cmd := "subscriber imsi " & hex2str(g_pars.imsi) & " silent-call ";

I'd better enclose this into a helper function so we only need to change it in one place if we ever […]

If there ever be more silent-call related TCs, I'll definitely add something like `f_vty_silent_call_{start,stop}()`. For now it's just two TCs and I think it's not a big problem if we merge it as-is.