Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email ) Change subject: msc: add TC_silent_call_{start_stop,active_conn} ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/299a305e_10b4a... : PS4, Line 7720: cmd := "subscriber imsi " & hex2str(g_pars.imsi) & " silent-call ";
I'd better enclose this into a helper function so we only need to change it in one place if we ever […] If there ever be more silent-call related TCs, I'll definitely add something like `f_vty_silent_call_{start,stop}()`. For now it's just two TCs and I think it's not a big problem if we merge it as-is.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de>