Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/b88887b8_948e2e6d?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. There seems to be a mixup of events when receiving an SCCP N-PCSTATE.ind handle_pcstate_ind in(), which ends up calling: cnlink_set_disconnected() cnlink_fsm_state_chg(cnlink->fi, CNLINK_ST_DISC) cnlink_disc_onenter() link_lost() context_map_cnlink_lost() map_sccp_dispatch(map, MAP_SCCP_EV_RAN_LINK_LOST, NULL) See how context_map_cnlink_lost() is sending event MAP_SCCP_EV_RAN_LINK_LOST, but that should actually be MAP_SCCP_EV_CN_LINK_LOST afaiu... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>