Attention is currently required from: laforge, neels.

View Change

1 comment:

• Commit Message:

  • Patch Set #2, Line 9:

    This event is never called. Furthermore, this kind of "SCCP link went
    down" should already be handled by libosmo-sigtran's sccp SAP
    internally, and we should simply recieve an N-DISCONNECT.ind when that
    happens which dispatches event MAP_SCCP_EV_RX_RELEASED.
    

    This is a related ticket which I recalled existed but was unable to find yesterday: https://osmocom. […]

    There seems to be a mixup of events when receiving an SCCP N-PCSTATE.ind handle_pcstate_ind in(), which ends up calling:

        cnlink_set_disconnected()
            cnlink_fsm_state_chg(cnlink->fi, CNLINK_ST_DISC)
                cnlink_disc_onenter()
                    link_lost()
                        context_map_cnlink_lost()
                            map_sccp_dispatch(map, MAP_SCCP_EV_RAN_LINK_LOST, NULL)
                            
    See how context_map_cnlink_lost() is sending event MAP_SCCP_EV_RAN_LINK_LOST, but that should actually be MAP_SCCP_EV_CN_LINK_LOST afaiu...

To view, visit change 40175. To unsubscribe, or for help writing mail filters, visit settings.