Attention is currently required from: osmith, laforge, fixeria.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/29311 )
Change subject: Debian: add osmocom user during package install
......................................................................
Patch Set 7:
(3 comments)
File debian/postinst:
https://gerrit.osmocom.org/c/osmo-hlr/+/29311/comment/efb8b90d_344020f7
PS7, Line 9: # install.
...and also to OE as you mentioned. probably here: […]
We have to keep our configuration files across (re)installs so DynamicUser= is
certainly not an option.
Regarding OE I think it's better to create the user/group via separate recipe/config
instead of per-service.
In case of spec/deb I think it's better to keep it on per-service level with
idempotent scripts since we do not have control over which parts (and in what order) of
Osmocom stack will be installed by user.
https://gerrit.osmocom.org/c/osmo-hlr/+/29311/comment/63f20111_e5bb8565
PS7, Line 29: --no-create-home \
why --no-create-home, do we already create the
directory structure?
We use StateDirectory as home so it's automatically created
by systemd for us.
https://gerrit.osmocom.org/c/osmo-hlr/+/29311/comment/11b48df4_5c18bdec
PS7, Line 37: chperms root osmocom 2775 /etc/osmocom
/var/lib/osmocom/hlr.db* also need to be changed from
root -> osmocom. […]
The permissions for StateDirectory and its content are
automatically adjusted by systemd to match unit's User/Group settings - see
https://www.freedesktop.org/software/systemd/man/systemd.exec.html
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/29311
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I625c993ab03dfe32976c651acca9c35c33a768e7
Gerrit-Change-Number: 29311
Gerrit-PatchSet: 7
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Sep 2022 12:51:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment