Attention is currently required from: osmith, laforge, fixeria.

View Change

3 comments:

• File debian/postinst:

  • Patch Set #7, Line 9: # install.

    ...and also to OE as you mentioned. probably here: […]

    We have to keep our configuration files across (re)installs so DynamicUser= is certainly not an option.

    Regarding OE I think it's better to create the user/group via separate recipe/config instead of per-service.

    In case of spec/deb I think it's better to keep it on per-service level with idempotent scripts since we do not have control over which parts (and in what order) of Osmocom stack will be installed by user.

  • Patch Set #7, Line 29: --no-create-home \

    why --no-create-home, do we already create the directory structure?

    We use StateDirectory as home so it's automatically created by systemd for us.

  • Patch Set #7, Line 37: chperms root osmocom 2775 /etc/osmocom

    /var/lib/osmocom/hlr.db* also need to be changed from root -> osmocom. […]

    The permissions for StateDirectory and its content are automatically adjusted by systemd to match unit's User/Group settings - see https://www.freedesktop.org/software/systemd/man/systemd.exec.html

To view, visit change 29311. To unsubscribe, or for help writing mail filters, visit settings.