Attention is currently required from: fixeria, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI ......................................................................

Patch Set 6:

(4 comments)

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/26345d42_0ff16... : PS6, Line 240: as_mm_identity

Maybe deriving two smaller altsteps (`as_mm_identity_imsi` and `as_mm_identity_imei`) from this one […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/97473fc5_104b6... : PS6, Line 265: as_receive_l3

This again looks 99% identical to the existing `f_receive_l3()`, so again code duplication. […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/70e12eb0_13c82... : PS6, Line 578: allow_id_imei_req

We may still receive an identity request here (regardless of the expectations), and this would block […]

Yes, but that is fine. The timer is here to fire on unexpected PDUs. I only care of IMEIs in this change.

Getting a second IMSI doesn't make really sense, because you already authenticated the user.

Also improving the current test case even more is IMHO out of scope of this change.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/fb558f99_336c5... : PS6, Line 579: f_process_attach_accept

(cosmetic, but) please move the function call to its own line.

Done