Attention is currently required from: fixeria, pespin.

View Change

4 comments:

• File sgsn/BSSGP_ConnHdlr.ttcn:

  • Patch Set #6, Line 240: as_mm_identity

    Maybe deriving two smaller altsteps (`as_mm_identity_imsi` and `as_mm_identity_imei`) from this one […]

    Done

  • Patch Set #6, Line 265: as_receive_l3

    This again looks 99% identical to the existing `f_receive_l3()`, so again code duplication. […]

    Done

  • Patch Set #6, Line 578: allow_id_imei_req

    We may still receive an identity request here (regardless of the expectations), and this would block […]

    Yes, but that is fine. The timer is here to fire on unexpected PDUs.
    I only care of IMEIs in this change.

    Getting a second IMSI doesn't make really sense, because you already authenticated the user.

    Also improving the current test case even more is IMHO out of scope of this change.

  • Patch Set #6, Line 579: f_process_attach_accept

    (cosmetic, but) please move the function call to its own line.

    Done

To view, visit change 38398. To unsubscribe, or for help writing mail filters, visit settings.