Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 )

Change subject: cbc: Test ETWS msg over CBSP ......................................................................

Patch Set 3:

(2 comments)

File cbc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/4c012693_93bf5... PS3, Line 101: var template (omit) uint8_t channel_ind := omit; AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit.

Could you explain why are you adding a separate template variable? What's wrong with passing msg.channel_ind directly?

File cbc/CBC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/47e68c4d_87a6a... PS3, Line 353: g_pars.exp_cbs_msg.channel_ind Here I guess you're doing ispresent() because g_pars.exp_cbs_msg may be omitted?