Attention is currently required from: osmith, pespin.

View Change

2 comments:

• File cbc/BSC_ConnectionHandler.ttcn:

  • Patch Set #3, Line 101: var template (omit) uint8_t channel_ind := omit;

    AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit.

    Could you explain why are you adding a separate template variable?
    What's wrong with passing msg.channel_ind directly?

• File cbc/CBC_Tests.ttcn:

  • Patch Set #3, Line 353: g_pars.exp_cbs_msg.channel_ind

    Here I guess you're doing ispresent() because g_pars.exp_cbs_msg may be omitted?

To view, visit change 28912. To unsubscribe, or for help writing mail filters, visit settings.