Attention is currently required from: Hoernchen, laforge, tnt, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27939 ) Change subject: coding: simplify detect_ahs_id_marker() ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: while I agree the function is now easier to read, the truth is you are adding 212 modulus operations (hence 212 division operations) every time this function is called. Not sure if this is really worth it, specially since this may be called lots of times. I'd like others to comment on this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Gerrit-Change-Number: 27939 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 14:10:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment