Attention is currently required from: Hoernchen, laforge, tnt, fixeria.

Patch set 4:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #4:

    while I agree the function is now easier to read, the truth is you are adding 212 modulus operations (hence 212 division operations) every time this function is called.
    Not sure if this is really worth it, specially since this may be called lots of times. I'd like others to comment on this.

To view, visit change 27939. To unsubscribe, or for help writing mail filters, visit settings.