Attention is currently required from: falconia, fixeria, manawyrm, roox. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35444?usp=email ) Change subject: isdn: initial implementation of the V.110 TA ...................................................................... Patch Set 13: Code-Review+1 (4 comments) File include/osmocom/isdn/v110_ta.h: https://gerrit.osmocom.org/c/libosmocore/+/35444/comment/7933d841_8cf23139 PS13, Line 22: struct osmo_v110_ta_cfg { imho each of these should be set through separate APIs. File src/isdn/v110_ta.c: https://gerrit.osmocom.org/c/libosmocore/+/35444/comment/bfbdcd28_c8eabbcc PS13, Line 152: static inline bool v110_df_x_bits_are(const struct osmo_v110_decoded_frame *df, ubit_t cmp) are what? rename? https://gerrit.osmocom.org/c/libosmocore/+/35444/comment/ce0ecfbe_01127ac7 PS13, Line 402: /* XXX: OSMO_ASSERT(V24_FLAGMASK_IS_ON(ts->v24_flags, OSMO_V110_TA_C_105)); */ why are these commented out? https://gerrit.osmocom.org/c/libosmocore/+/35444/comment/73156dcd_ba31dbd2 PS13, Line 437: /* TODO: if (ta->cfg->flow_ctrl.end_to_end) { ... } */ this is left for later? not important? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5716bd6fd0201ee7a7a29e72f775972cd374082f Gerrit-Change-Number: 35444 Gerrit-PatchSet: 13 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 09:50:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment