Attention is currently required from: falconia, fixeria, manawyrm, roox.

Patch set 13:Code-Review +1

View Change

4 comments:

• File include/osmocom/isdn/v110_ta.h:

  • Patch Set #13, Line 22: struct osmo_v110_ta_cfg {

    imho each of these should be set through separate APIs.

• File src/isdn/v110_ta.c:

  • Patch Set #13, Line 152: static inline bool v110_df_x_bits_are(const struct osmo_v110_decoded_frame *df, ubit_t cmp)

    are what?
    rename?

  • Patch Set #13, Line 402: /* XXX: OSMO_ASSERT(V24_FLAGMASK_IS_ON(ts->v24_flags, OSMO_V110_TA_C_105)); */

    why are these commented out?

  • Patch Set #13, Line 437: /* TODO: if (ta->cfg->flow_ctrl.end_to_end) { ... } */

    this is left for later? not important?

To view, visit change 35444. To unsubscribe, or for help writing mail filters, visit settings.