Attention is currently required from: osmith, jolly, fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33296 ) Change subject: ASCI: Retrieve NCH position from System Information 1 ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/5360e140_2de2be1e PS6, Line 177: /* H <NCH Position : bit (5)> */ This is CSN.1, maybe put a spec reference here as well? https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/0017c8fa_2a430e5e PS6, Line 180: return -EINVAL; maybe ENOTSUP? I think also important would be a comment to explain that this is not an error. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I799a27179d478d4ff577d8bc47ae524834851e85 Gerrit-Change-Number: 33296 Gerrit-PatchSet: 6 Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 18 Jul 2023 14:30:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-MessageType: comment