Attention is currently required from: osmith, jolly, fixeria, pespin.

Patch set 6:Code-Review +1

View Change

2 comments:

• File src/common/sysinfo.c:

  • Patch Set #6, Line 177: /* H <NCH Position : bit (5)> */

    This is CSN.1, maybe put a spec reference here as well?

  • Patch Set #6, Line 180: return -EINVAL;

    It's not really an error, it's just "NCH not present" AFAIU. […]

    maybe ENOTSUP? I think also important would be a comment to explain that this is not an error.

To view, visit change 33296. To unsubscribe, or for help writing mail filters, visit settings.