Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39948?usp=email )

Change subject: client: use pcap_dispatch to avoid extra pkt buffer copy ......................................................................

Patch Set 2:

(2 comments)

File src/osmo_client_core.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39948/comment/f8a8c2f6_4763f34e?usp... : PS2, Line 464: == -1 Maybe it's better to check `!= 0` instead? Looking at the man page, I see it may return `PCAP_ERROR_NOT_ACTIVATED` and `PCAP_ERROR`. Note that `errbuf` is only set if returned value is `PCAP_ERROR`.

https://gerrit.osmocom.org/c/osmo-pcap/+/39948/comment/3fb383b6_8f19f4b7?usp... : PS2, Line 464: one Why not just passing `1`? It needs a value, not a pointer.