Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmo_client_core.c:

  • Patch Set #2, Line 464: == -1

    Maybe it's better to check `!= 0` instead? Looking at the man page, I see it may return `PCAP_ERROR_NOT_ACTIVATED` and `PCAP_ERROR`. Note that `errbuf` is only set if returned value is `PCAP_ERROR`.

  • Patch Set #2, Line 464: one

    Why not just passing `1`? It needs a value, not a pointer.

To view, visit change 39948. To unsubscribe, or for help writing mail filters, visit settings.