Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 )

Change subject: abis_om2000: move switch-case to function ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File src/osmo-bsc/abis_om2000.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/af588b0d_e47201dc PS1, Line 997: switch (mo->class) { You can probably move this inside oml_avstate_from_om2k_mostate() too, and pass mo->class there as a param.

https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/01355f18_821ba2a7 PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state) it's a bit strange that a function starting with "oml_opstate" returns a "abis_nm_op_state" don't you think? :D