Attention is currently required from: dexter.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/osmo-bsc/abis_om2000.c:

  • Patch Set #1, Line 997: switch (mo->class) {

    You can probably move this inside oml_avstate_from_om2k_mostate() too, and pass mo->class there as a param.

  • Patch Set #1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state)

    it's a bit strange that a function starting with "oml_opstate" returns a "abis_nm_op_state" don't you think? :D

To view, visit change 28914. To unsubscribe, or for help writing mail filters, visit settings.