Attention is currently required from: falconia.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32078 )

Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case ......................................................................

Patch Set 1:

(1 comment)

File src/trau/trau_rtp_conv.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/32078/comment/5c57d3f4_d600991e PS1, Line 282: } else if (data_len == 0) { : /* C1 .. C5: idle speech */ : tf->c_bits[0] = 0; : tf->c_bits[1] = 1; : tf->c_bits[2] = 1; : tf->c_bits[3] = 1; : tf->c_bits[4] = 0; Shouldn't this clause come before/independent of the UL/DL if/else clause?

Basically above where the "FIXME: Generate SID frames?" comment is (which is no longer a FIXME then.

In general the control flow of this function is rather hard to follow with your change. We also have another UL / data_len == 0 clause below, and last but not least yet another one at the bottom. I think there mus be a way to do this more straight-forward.