Attention is currently required from: falconia.

View Change

1 comment:

• File src/trau/trau_rtp_conv.c:

  • Patch Set #1, Line 282:

    } else if (data_len == 0) {
    		/* C1 .. C5: idle speech */
    		tf->c_bits[0] = 0;
    		tf->c_bits[1] = 1;
    		tf->c_bits[2] = 1;
    		tf->c_bits[3] = 1;
    		tf->c_bits[4] = 0;
    

    Shouldn't this clause come before/independent of the UL/DL if/else clause?

    Basically above where the "FIXME: Generate SID frames?" comment is (which is no longer a FIXME then.

    In general the control flow of this function is rather hard to follow with your change. We also have another UL / data_len == 0 clause below, and last but not least yet another one at the bottom. I think there mus be a way to do this more straight-forward.

To view, visit change 32078. To unsubscribe, or for help writing mail filters, visit settings.